Update lc functions to use the dev branch of CL specs
#14471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rupam-04
commented
Sep 24, 2024
rupam-04
force-pushed
the
update-to-dev
branch
from
7fd78a5
to
2636413
Compare
rupam-04
force-pushed
the
update-to-dev
branch
from
2636413
to
6f987a2
Compare
rupam-04
changed the title
dev branch of CL specsdev branch of CL specs
rupam-04
force-pushed
the
update-to-dev
branch
from
7b6410a
to
e5fa63b
Compare
rkapka
reviewed
Oct 3, 2024
rkapka
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be reviewed after #14468
#14457 -> #14468 -> #14471
What type of PR is this?
Other
What does this PR do? Why is it needed?
Upgrades the
createLightClientBootstrapfunction to reference thedevbranch of CL specs. The current implementation works fine for Altair but upgrading it would make the implementations for newer forks easier. I also rebased @Inspector-Butters 's fix-lc-execution-header-bug branch on top of mine as he had to update theNewLightClientUpdateFromBeaconStatefunction for his PR #14468Which issues(s) does this PR fix?
Partially addresses #12991
Other notes for review
Acknowledgements