adding nil checks on attestation interface

CHANGELOG.md

@@ -79,6 +79,7 @@ The format is based on Keep a Changelog, and this project adheres to Semantic Ve
 - Small log imporvement, removing some redundant or duplicate logs
 - EIP7521 - Fixes withdrawal bug by accounting for pending partial withdrawals and deducting already withdrawn amounts from the sweep balance. [PR](https://github.com/prysmaticlabs/prysm/pull/14578)
 - unskip electra merkle spec test
+- corrects nil check on some interface attestation types
 
 
 ### Security

beacon-chain/core/helpers/attestation.go

@@ -23,22 +23,7 @@ var (
 // Access to these nil fields will result in run time panic,
 // it is recommended to run these checks as first line of defense.
 func ValidateNilAttestation(attestation ethpb.Att) error {
-	if attestation == nil {
-		return errors.New("attestation can't be nil")
-	}
-	if attestation.GetData() == nil {
-		return errors.New("attestation's data can't be nil")
-	}
-	if attestation.GetData().Source == nil {
-		return errors.New("attestation's source can't be nil")
-	}
-	if attestation.GetData().Target == nil {
-		return errors.New("attestation's target can't be nil")
-	}
-	if attestation.GetAggregationBits() == nil {
-		return errors.New("attestation's bitfield can't be nil")
-	}
-	return nil
+	return attestation.IsNil()
 }
 
 // ValidateSlotTargetEpoch checks if attestation data's epoch matches target checkpoint's epoch.

beacon-chain/db/slasherkv/slasher.go

@@ -688,9 +688,12 @@ func decodeSlasherChunk(enc []byte) ([]uint16, error) {
 // Encode attestation record to bytes.
 // The output encoded attestation record consists in the signing root concatenated with the compressed attestation record.
 func encodeAttestationRecord(att *slashertypes.IndexedAttestationWrapper) ([]byte, error) {
-	if att == nil || att.IndexedAttestation == nil {
+	if att == nil {
 		return []byte{}, errors.New("nil proposal record")
 	}
+	if err := att.IndexedAttestation.IsNil(); err != nil {
+		return []byte{}, err
+	}
 
 	// Encode attestation.
 	encodedAtt, err := att.IndexedAttestation.MarshalSSZ()

beacon-chain/operations/attestations/kv/block.go

@@ -8,7 +8,8 @@ import (
 
 // SaveBlockAttestation saves an block attestation in cache.
 func (c *AttCaches) SaveBlockAttestation(att ethpb.Att) error {
-	if att == nil {
+	if err := att.IsNil(); err != nil {
+		//nolint:nilerr
 		return nil
 	}
 

beacon-chain/operations/attestations/kv/forkchoice.go

@@ -8,7 +8,8 @@ import (
 
 // SaveForkchoiceAttestation saves an forkchoice attestation in cache.
 func (c *AttCaches) SaveForkchoiceAttestation(att ethpb.Att) error {
-	if att == nil {
+	if err := att.IsNil(); err != nil {
+		//nolint:nilerr
 		return nil
 	}
 
@@ -50,7 +51,8 @@ func (c *AttCaches) ForkchoiceAttestations() []ethpb.Att {
 
 // DeleteForkchoiceAttestation deletes a forkchoice attestation in cache.
 func (c *AttCaches) DeleteForkchoiceAttestation(att ethpb.Att) error {
-	if att == nil {
+	if err := att.IsNil(); err != nil {
+		//nolint:nilerr
 		return nil
 	}
 

beacon-chain/operations/attestations/kv/unaggregated.go

@@ -14,7 +14,8 @@ import (
 
 // SaveUnaggregatedAttestation saves an unaggregated attestation in cache.
 func (c *AttCaches) SaveUnaggregatedAttestation(att ethpb.Att) error {
-	if att == nil {
+	if err := att.IsNil(); err != nil {
+		//nolint:nilerr
 		return nil
 	}
 	if helpers.IsAggregated(att) {
@@ -130,7 +131,8 @@ func (c *AttCaches) UnaggregatedAttestationsBySlotIndexElectra(
 
 // DeleteUnaggregatedAttestation deletes the unaggregated attestations in cache.
 func (c *AttCaches) DeleteUnaggregatedAttestation(att ethpb.Att) error {
-	if att == nil {
+	if err := att.IsNil(); err != nil {
+		//nolint:nilerr
 		return nil
 	}
 	if helpers.IsAggregated(att) {
@@ -161,7 +163,10 @@ func (c *AttCaches) DeleteSeenUnaggregatedAttestations() (int, error) {
 
 	count := 0
 	for r, att := range c.unAggregatedAtt {
-		if att == nil || helpers.IsAggregated(att) {
+		if err := att.IsNil(); err != nil {
+			continue
+		}
+		if helpers.IsAggregated(att) {
 			continue
 		}
 		if seen, err := c.hasSeenBit(att); err == nil && seen {

beacon-chain/slasher/helpers.go

@@ -97,10 +97,7 @@ func (s *Service) filterAttestations(
 // detection (except for the genesis epoch).
 func validateAttestationIntegrity(att ethpb.IndexedAtt) bool {
 	// If an attestation is malformed, we drop it.
-	if att == nil ||
-		att.GetData() == nil ||
-		att.GetData().Source == nil ||
-		att.GetData().Target == nil {
+	if err := att.IsNil(); err != nil {
 		return false
 	}
 

beacon-chain/state/stateutil/field_root_attestation.go

@@ -48,7 +48,7 @@ func EpochAttestationsRoot(atts []*ethpb.PendingAttestation) ([32]byte, error) {
 }
 
 func pendingAttestationRoot(att *ethpb.PendingAttestation) ([32]byte, error) {
-	if att == nil {
+	if err := att.IsNil(); err != nil {
 		return [32]byte{}, errors.New("nil pending attestation")
 	}
 	return PendingAttRootWithHasher(att)