Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move get data after nil check for attestations #14642

Merged
merged 2 commits into from
Nov 15, 2024
Merged

move get data after nil check for attestations #14642

merged 2 commits into from
Nov 15, 2024

Conversation

james-prysm
Copy link
Contributor

@james-prysm james-prysm commented Nov 15, 2024 •
edited
Loading

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

introduced as part of #14085, this moves the get data safely after the validation

Which issues(s) does this PR fix?

Fixes #

Other notes for review

Acknowledgements

  • I have read CONTRIBUTING.md.
  • I have made an appropriate entry to CHANGELOG.md.
  • I have added a description to this PR with sufficient context for reviewers to understand this PR.

@james-prysm james-prysm added Bug Something isn't working Electra electra hardfork labels Nov 15, 2024
@james-prysm james-prysm requested a review from a team as a code owner November 15, 2024 18:08
@james-prysm james-prysm added this pull request to the merge queue Nov 15, 2024
Merged via the queue into develop with commit 9dbf979 Nov 15, 2024
18 checks passed
@james-prysm james-prysm deleted the fix-potential-attestation-panic branch November 15, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasey kasey kasey approved these changes

@nalepae nalepae Awaiting requested review from nalepae nalepae is a code owner automatically assigned from prysmaticlabs/core-team

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon prestonvanloon is a code owner automatically assigned from prysmaticlabs/core-team

@saolyn saolyn Awaiting requested review from saolyn saolyn is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
Bug Something isn't working Electra electra hardfork
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@james-prysm @kasey