Remove use of ternary operator.

przemek83 · Oct 11, 2024 · 45dac21 · 45dac21
1 parent 3fcd5b7
commit 45dac21
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/Tank.cpp b/src/Tank.cpp
@@ -13,7 +13,7 @@ Tank::Tank(TankType tankType, Point point)
     : Drawable(point), initialX_(point.x_), initialY_(point.y_)
 {
     setType(tankType);
-    direction_ = (isPlayerControlled() ? Direction::UP : Direction::DOWN);
+    resetDirection();
 }
 
 void Tank::draw(const Display& display) const
@@ -188,7 +188,7 @@ void Tank::respawn()
     setY(initialY_);
     if (isPlayerControlled())
         setType(TankType::PLAYER_TIER_1);
-    direction_ = (isPlayerControlled() ? Direction::UP : Direction::DOWN);
+    resetDirection();
 }
 
 void Tank::adjustEnemySpeed(float& speed) const
@@ -205,3 +205,11 @@ int Tank::getCalculatedSpeed(float speedFactor) const
         adjustEnemySpeed(speed);
     return std::max(1, static_cast<int>(speed));
 }
+
+void Tank::resetDirection()
+{
+    if (isPlayerControlled())
+        direction_ = Direction::UP;
+    else
+        direction_ = Direction::DOWN;
+}
diff --git a/src/Tank.h b/src/Tank.h
@@ -58,6 +58,8 @@ class Tank : public Drawable
 
     bool destroy();
 
+    void resetDirection();
+
     static const int BASIC_ATTACK{1};
     static const int BASIC_HEALTH{1};
     static const int BASIC_SPEED{2};