Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fluidsynth support to the PS2. #139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

7dog123
Copy link

@7dog123 7dog123 commented Mar 29, 2024

Using my forked version of https://github.com/DominusExult/fluidsynth-sans-glib/tree/sans_glib which removes glib support from fluidsynth with a little sloppy modification to add PS2 Support while adding a patch from VolcanoMobile/fluidsynth-android@cc72153#diff-9b72ca5f74c5da05204f881e94c67c02080ee1adbabfb06571ab3ca28e06569e but using a if and else statement to add compatability to the PS2 by switching from atomic to using a global mutex for the PS2.

@Wolf3s
Copy link
Contributor

Wolf3s commented Mar 30, 2024

Hey, there nice basic port, Did you tested this on some source-port?

@7dog123
Copy link
Author

7dog123 commented Mar 30, 2024

Not yet exactly. I'm trying to work on another project that uses Fluidsynth. I'm trying to port DoomRPG-RE to the PS2 since it uses fluidsynth as well as SDL2 and SDL2_mixer

@Wolf3s
Copy link
Contributor

Wolf3s commented Mar 30, 2024

Not yet exactly. I'm trying to work on another project that uses Fluidsynth. I'm trying to port DoomRPG-RE to the PS2 since it uses fluidsynth as well as SDL2 and SDL2_mixer

DoomRPG-RE by gec on ps2 would be awesome although it´s seems to easy to port it, i could say that D64EX+ can be portable since on linux works well.

@Wolf3s
Copy link
Contributor

Wolf3s commented Mar 30, 2024

obviously with this pull.

@7dog123
Copy link
Author

7dog123 commented Mar 30, 2024

Yeah, but lets take this conversation for DoomRPG-RE on my fork of it and away from this pull request.

@Wolf3s
Copy link
Contributor

Wolf3s commented Mar 30, 2024

Yeah, but lets take this conversation for DoomRPG-RE on my fork of it and away from this pull request.

Ok then, i saw you forked DoomRPG-RE.

@fjtrujy
Copy link
Member

fjtrujy commented Apr 5, 2024

I'm totally fine adding this dependency, however how this is not the official fork, we would like to fork it in our side (ps2dev) a push the changes to a concrete branch called ee-VX.Y.Z where X.Y.Z belongs to the concrete version of the original library.

So if you agree, let me know the proper version, I will fork the original repo, and create that specific branch, and then you can perform a PR to that branch with your changes adding the PS2 support.

@7dog123
Copy link
Author

7dog123 commented Apr 6, 2024

It uses the current version that's out as of now 2.3.5

@Wolf3s
Copy link
Contributor

Wolf3s commented Apr 6, 2024

It uses the current version that's out as of now 2.3.5

Can you patch it with no sans-lib?

@fjtrujy
Copy link
Member

fjtrujy commented Apr 27, 2024

It uses the current version that's out as of now 2.3.5

Sorry I have been busy, do you want me to fork it then?

Give the exact repo to fork and I will fork it in the ps2dev group

@7dog123
Copy link
Author

7dog123 commented Apr 28, 2024

It uses the current version that's out as of now 2.3.5

Sorry I have been busy, do you want me to fork it then?

Give the exact repo to fork and I will fork it in the ps2dev group

It's alright and here's the repo I used.

https://github.com/DominusExult/fluidsynth-sans-glib and the branch that removes glib is sans_glib

@fjtrujy
Copy link
Member

fjtrujy commented May 6, 2024

It uses the current version that's out as of now 2.3.5

Sorry I have been busy, do you want me to fork it then?
Give the exact repo to fork and I will fork it in the ps2dev group

It's alright and here's the repo I used.

https://github.com/DominusExult/fluidsynth-sans-glib and the branch that removes glib is sans_glib

Here you have the branch pushed https://github.com/ps2dev/fluidsynth/tree/ee-sans_glib
Now you can make a PR to that specific branch with the specific PS2 changes.
Then once merged you can also use this on the ps2sdk-port (with cmake if possible)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants