timer: Fix TimerBusClock2USec #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested this now and it seems to work fine. After this change the test from #416 now generates valid unix timestamps and the assert never fails. |
fjtrujy
approved these changes
Nov 26, 2023
There was a problem hiding this comment.
I’m fine wit this change, it makes sense to me.
Anyway, I will wait till @davidgfnet double-check it, because he is the author of this.
Cheers
|
Validated against my notes. This is fine, merging |
|
Yup that's correct, it was returning clocks instead of usecs. Not sure what happened there :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #416