Fix relative paths #466
Merged
Fix relative paths #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uyjulian
reviewed
Dec 3, 2023
fjtrujy
commented
Dec 3, 2023
| strcpy(b_fname, "host:"); | ||
| strcpy(b_fname + 5, __direct_pwd); | ||
| if (!(__direct_pwd[b_fname_len - 1] == '/' || __direct_pwd[b_fname_len - 1] == '\\')) { // does it has trailing slash ? | ||
| if(isCdromPath(b_fname)) { |
There was a problem hiding this comment.
Is this thing really needed?
I don't know why but it compares If unit is cdrom and then adding \\ is that something legacy? maybe from windows?
@uyjulian @rickgaiser , do you know something about this?
There was a problem hiding this comment.
This is the correct behavior. In the versions of cdvdman I've checked CdSearchFile checks for backslashes (and not forward slashes)
fjtrujy
force-pushed
the
fix_relative_paths
branch
from
fd06667
to
f2b6daa
Compare
fjtrujy
force-pushed
the
fix_relative_paths
branch
from
f2b6daa
to
9365e96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the method that transforms the relative path into absolute paths, something needs to support POSIX functions with relative paths.
Specific content for
cwdand paths has been moved to a separate file.The returned error for several functions has been improved.
Once again the base code has been taken from the PSPSDK.
Cheers.