Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Collection stub for newer doctrine/collections versions #149

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

Mika56
Copy link

@Mika56 Mika56 commented Oct 24, 2023

Refs #21 and #138

Rebased old commit on 2.x branch

This commit disables doctrine/collections stubs when the installed version of doctrine/collections is >=1.6.0, when they started adding their own, more correct, stubs

@orklah
Copy link
Collaborator

orklah commented Oct 24, 2023

Thanks! It does make a lot of tests fail though

@Mika56
Copy link
Author

Mika56 commented Jan 25, 2024

Can you restart the tests?

php low stable high
7.2
7.3
7.4
8.0

Seems to be broken on 7.2, 7.3, and low versions on 7.4 and 8.0. Probably something to do with the Doctrine version check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants