Fix frequency-dependent iterative CPHF #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgasmith
reviewed
Jan 20, 2020
| # Build initial guess, previous vectors, and DIIS objects | ||
| norb = self.scf_wfn.nmo() | ||
| C = np.asarray(self.C) | ||
| rhsmats = [C.T @ np.asarray(dipmat) @ C for dipmat in self.tmp_dipoles] |
There was a problem hiding this comment.
Could you use np.dot here. I do like the @ syntax better, just not sure if people are ready for it yet.
dgasmith
approved these changes
Jan 22, 2020
|
It is lost to the ages what the actual problem with the iterative solver was (something with separate response vectors rather than a single combined U?), but I had left this draft in the hopes of referencing another paper or two, but clearly that didn't happen. The code has been done the entire time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug where the list holding response vectors (
self.x) wasn't cleared was hiding the fact thatsolve_dynamic_iterativewas not correct.