forked from dagster-io/dagster
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ui] Add min-height to breadcrumbs to fix layout loop caused by Middl…
…eTruncate RAF (dagster-io#26127) ## Summary & Motivation Fixes the flickering observed in https://dagsterlabs.slack.com/archives/C03CZRZCZQQ/p1732546935350479. When the sizing is async, the height of the element was briefly reduced to the height of the `•••`, which causes an infinite loop of re-rendering. The "30px" minimum height is the default value that would be set if we were not overriding it here. Also added a storybook so we can easily verify this behavior in the future: <img width="931" alt="image" src="https://github.com/user-attachments/assets/5430f23a-f437-407c-97a1-336b6e09c67e"> ## How I Tested These Changes I added a storybook with the same code as the header and verified the flickering is no longer an issue. Co-authored-by: bengotow <[email protected]>
- Loading branch information
1 parent
e60e005
commit 6b63ff5
Showing
4 changed files
with
72 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,5 +48,6 @@ const PageHeaderContainer = styled(Box)` | |
*/ | ||
.bp5-breadcrumbs { | ||
height: auto; | ||
min-height: 30px; | ||
} | ||
`; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters