WIP: Make inline all the GU methods #227
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjtrujy
changed the title
fjtrujy
force-pushed
the
inline_gu
branch
2 times, most recently
from
5c0595a to
727b7a2
Compare
|
Any news about this cool PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR follows kind of similar approach to the one done #172
This function makes
static inlinethe majority of thelibgufunctions.The way it has been done was basically to put all the implementations within the
pspgu.h.What are the consequences:
pspgu.hnow contains at the bottom of the file all the implementations.Additionally, some other minor changes and clean-ups have been done.
Please, if possible test it with your apps, I have tested it with several of the
samples/gu,picodriveanddaedalusso far it has increased performance in a couple of FPS.PD: Looks like the official PSP SDK did it in the same way.
Cheers.