-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create build.txt with build information #39
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the .git directory will not exist
Otherwise there won't be a .git directory and creating the build.txt file will fail.
This should fix the git checkout
This makes it work on MacOS
There is currently still a poll open about what the exact path of the build information file should be. I'll update this PR once the result is in. |
In the poll it was decided the the current location was the best one. We'll stick to that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So what this does is create the file
$PSPDEV/build.txt
which looks like this:It will also replace that line in the build.txt file if there already is a psptoolchain-allegrex entry.
It took some fiddling to get the .git in the docker build environments, but I managed to make it work. Please squish this PR. I would like to add a PR like this for each repo in the build chain. psptoolchain will probably be the most annoying to do, since it's combining 2 repos.
Please squish this if this is merged. Most of the changes here are not useful by themselves and were me testing this change in my fork.