[WRAPPED] Added monstartup

[xiangzhai]

Hi,

before:

Error: Symbol monstartup not found, cannot apply R_X86_64_JUMP_SLOT @0x3f096d4ef0 (0x4b346) in /yourpath/x64.so
Error: relocating Plt symbols in elf x64.so
Error initializing needed lib /yourpath/x64.so
Exception in thread "main" java.lang.ExceptionInInitializerError: initialization failed with java.lang.UnsatisfiedLinkError: /yourpath/x64.so: Cannot dlopen("/yourpath/x64.so"/0xffec4ba3b0, 1)

after:
work :)

Please review my patch.

Thanks,
Leslie Zhai

[ptitSeb]

The doc I found state this:

       void
       monstartup(u_long lowpc,	u_long highpc);

and my local include file is similar.
so, signature should be vFLL instead. Were did you found iFpp?

[xiangzhai]

int monstartup(caddr_t LowProgramCounter, caddr_t HighProgramCounter);

https://www.ibm.com/docs/zh-tw/aix/7.1?topic=m-monstartup-subroutine

And caddr_t:

typedef char *__caddr_t;
typedef __caddr_t caddr_t;

Thanks,
Leslie Zhai

[xiangzhai]

@ptitSeb you are correct:

/usr/include/loongarch64-linux-gnu/sys/gmon.h:194:extern void monstartup (unsigned long __lowpc, unsigned long __highpc) __THROW;

Thanks,
Leslie Zhai

[ksco]

Check this tutorial for the basics of libwrapping: https://box86.org/2024/02/how-to-create-a-wrapping/

[xiangzhai]

And it should use GO but not GOW, because the symbol monstartup is not STB_WEAK:

Error: Symbol monstartup not found, cannot apply R_X86_64_JUMP_SLOT @0x3f096d4ef0 (0x4b346) in /yourpath/x64.so

https://github.com/ptitSeb/box64/blob/main/src/elfs/elfloader.c#L713

Please point out my fault.

Thanks,
Leslie Zhai

[ptitSeb]

And it should use GO but not GOW, because the symbol monstartup is not STB_WEAK:

Error: Symbol monstartup not found, cannot apply R_X86_64_JUMP_SLOT @0x3f096d4ef0 (0x4b346) in /yourpath/x64.so

https://github.com/ptitSeb/box64/blob/main/src/elfs/elfloader.c#L713

Please point out my fault.

Thanks, Leslie Zhai

For static build, you might need to look at static_libc.h and create the function signature there.

[ptitSeb]

And it should use GO but not GOW, because the symbol monstartup is not STB_WEAK:

Error: Symbol monstartup not found, cannot apply R_X86_64_JUMP_SLOT @0x3f096d4ef0 (0x4b346) in /yourpath/x64.so

https://github.com/ptitSeb/box64/blob/main/src/elfs/elfloader.c#L713

Please point out my fault.

Thanks, Leslie Zhai

On my system, that symbol is Weak:

seb@D2000:/data/Games/x86$ nm -D /usr/lib/aarch64-linux-gnu/libc.so.6 | grep monstartup
00000000000f2780 T __monstartup@@GLIBC_2.17
00000000000f2780 W monstartup@@GLIBC_2.17

[xiangzhai]

Hi @ptitSeb please wait for my local staticbuild test.

Thanks,
Leslie Zhai

[xiangzhai]

On my system, that symbol is Weak:

seb@D2000:/data/Games/x86$ nm -D /usr/lib/aarch64-linux-gnu/libc.so.6 | grep monstartup
00000000000f2780 T __monstartup@@GLIBC_2.17
00000000000f2780 W monstartup@@GLIBC_2.17

Thanks for pointing out my fault monstartup is WEAK symbol:

$ nm -D /usr/lib/loongarch64-linux-gnu/libc.so.6 |grep monstartup
00000000000dfd40 T __monstartup
00000000000dfd40 W monstartup