Reduce Ruby warnings in recent builds #345

jywarren · 2019-02-19T22:48:57Z

We're looking at upgrading Ruby in #319 and i'm seeing a lot of warning messages that weren't previously there in the recent #341 PR, which make it hard to read the output:

https://travis-ci.org/publiclab/mapknitter/builds/494340774

@sashadev-sky @gauravano @SidharthBansal what do you think, is this just stricter behavior from a more recent version of Ruby, or what else can we do to reduce the # of warnings? Thank you!

Just to note, it's not just in #341, i guess; this recent main branch build has lots too:

https://travis-ci.org/publiclab/mapknitter/builds/493792946

The text was updated successfully, but these errors were encountered:

jywarren · 2019-02-19T22:53:02Z

Looks like we're in Ruby 2.1.x in all these, so dunno if it's related to newer ruby versions. Errors sampling:

/usr/local/lib/ruby/gems/2.1.0/gems/will_paginate-3.1.6/lib/will_paginate/railtie.rb:1: warning: loading in progress, circular require considered harmful - /usr/local/lib/ruby/gems/2.1.0/gems/will_paginate-3.1.6/lib/will_paginate.rb

/usr/local/lib/ruby/gems/2.1.0/gems/railties-3.2.22.5/lib/rails/application.rb:98: warning: File.exists? is a deprecated name, use File.exist? instead

/usr/local/lib/ruby/gems/2.1.0/gems/will_paginate-3.1.6/lib/will_paginate/core_ext.rb:8: warning: previous definition of except was here
/usr/local/lib/ruby/gems/2.1.0/gems/activesupport-3.2.22.5/lib/active_support/core_ext/hash/except.rb:19: warning: method redefined; discarding old except!

/usr/local/lib/ruby/gems/2.1.0/gems/activesupport-3.2.22.5/lib/active_support/dependencies.rb:251: warning: loading in progress, circular require considered harmful - /usr/local/lib/ruby/gems/2.1.0/gems/ruby-openid-2.7.0/lib/openid.rb
	from /usr/local/lib/ruby/gems/2.1.0/gems/rake-12.3.2/lib/rake/rake_test_loader.rb:5:in  `<main>'
	from /usr/local/lib/ruby/gems/2.1.0/gems/rake-12.3.2/lib/rake/rake_test_loader.rb:5:in  `select'
	from /usr/local/lib/ruby/gems/2.1.0/gems/rake-12.3.2/lib/rake/rake_test_loader.rb:17:in  `block in <main>'
	from /usr/local/lib/ruby/gems/2.1.0/gems/rake-12.3.2/lib/rake/rake_test_loader.rb:17:in  `require'
	from /app/test/unit/comment_test.rb:1:in  `<top (required)>'
	from /app/test/unit/comment_test.rb:1:in  `require'
	from /app/test/test_helper.rb:2:in  `<top (required)>'
	from /app/test/test_helper.rb:2:in  `require'
	from /app/config/environment.rb:5:in  `<top (required)>'
	from /usr/local/lib/ruby/gems/2.1.0/gems/railties-3.2.22.5/lib/rails/railtie/configurable.rb:30:in  `method_missing'

Hm, also looking back a ways, this didn't have the errors but is actually ruby 2.1.2 also: https://travis-ci.org/publiclab/mapknitter/builds/410929149

grvsachdeva · 2019-02-20T08:27:13Z

After a quick look at the above build logs point to deprecated File.exists? as a cause of these warnings, I will see if the #320 throws the same warning or not. Thanks!

sashadev-sky · 2019-02-21T07:21:55Z

@gauravano @jywarren I will get involved with this too during mysql upgrade. If they are simple fixes I can always update them in that PR

sashadev-sky · 2019-03-27T05:23:10Z

Copying over some information from my PRs #380 and #355 related to this:

Warning ::Fixnum is deprecated error: this warning will be fixed with an update to Rails 5. see here
File.exists? (deprecated since ruby 2.2.0) updated to File.exist? comes from gems and from the source code for running a rake test. Source code is updated to File.exist? for Rails 4.

Problem gems:

paperclip seems to cause the greatest number of errors including errors mentioned above
- Dependabot recommended update to 4.3.7 confirming this update is compatible but does not get rid of any warnings.
- Recommended solution is to wait for upgrade to Rails 5.2 and then migrate away from Paperclip as its been deprecated: see here
- also seeing: DEPRECATION WARNING: [paperclip] [deprecation] Rails 3.2 and 4.1 are unsupported as of Rails 5 release. Please upgrade to Rails 4.2 before upgrading paperclip. (called from class:Warpable at /Users/sashaboginsky/Desktop/public lab/mapknitter/app/models/warpable.rb:8)
ruby-openid
- updating to latest version does not get rid of errors but I see a PR open on the gem page that would fix some of the warnings currently receiving (unused parameters, file.exists?)
open_id_authentication
will_paginate
- already updated but PR currently open on the gem page to get rid of circular warnings error
friendly_id
- Updated versions removed support for Rails < 4.0. see here so maybe try catching up to Rails 4.0 first

sashadev-sky · 2019-03-27T05:24:57Z

@jywarren from my comment above, should I open a PR to update to Rails 4 next to try to resolve some of the File.exists and maybe friendly_id errors?

also just saw this update is part of a gsoc proposal here so can also leave it for this person and link them my notes on the proposal page

jywarren · 2019-03-30T01:16:08Z

sure! Thank you!!!

…

On Wed, Mar 27, 2019 at 1:25 AM Sasha Boginsky ***@***.***> wrote: @jywarren <https://github.com/jywarren> from my comment above, should I open a PR to update to Rails 4 next to try to resolve some of the File.exists and maybe friendly_id errors? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#345 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJx-sjs65bgr0FZBvpp8ZSenc-JhFks5vawCpgaJpZM4bEB8p> .

kaustubh-nair · 2019-03-30T06:25:52Z

@sashadev-sky Sure that will be awesome. I can take up that issue!
Thanks!

alaxalves · 2019-04-02T22:04:43Z

@sashadev-sky A lot of those warnings will be missing in Rails Upgrade. I empirically upgraded to Rails 4.2.8 here and a lot of those warning have gone missing.

jywarren · 2019-04-02T22:41:36Z

:-) awesome!!!

…

On Tue, Apr 2, 2019 at 6:05 PM Álax de Carvalho Alves < ***@***.***> wrote: A lot of those warnings will be missing in Rails Upgrade. I empirically upgraded to Rails 4.2.8 here <https://github.com/alaxalves/mapknitter/tree/rails4> and a lot of those warning have gone missing. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#345 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ3G5Cu6erIIf_H9qCfZdxAlzCS0lks5vc9P7gaJpZM4bEB8p> .

sashadev-sky · 2019-04-03T02:08:42Z

@alaxalves Thank you that is great to hear! I'm going to open an issue regarding upgrading to Rails 4.0 to take it one step at a time. I will tag you there, let me know if you remember any gems or custom configs you remember having to update.

I'll also just look at the version you tagged a link to to see

alaxalves · 2019-04-03T12:37:48Z

@sashadev-sky The greatest approach to this is gradually updating versions, such as 3.2 to the next release. eg. rails 3.2 to rails 3.3. using the appropriate rake task. I'll try to make all those steps clearer in my GSoC proposal. I'll finish it today(04/03/2019) and I submit the link here. What do you think?

jywarren · 2019-04-18T17:26:40Z

I think we're doing MUCH better here now, and can close up and focus on Rails upgrades!!!

jywarren · 2019-04-18T17:26:43Z

https://travis-ci.org/publiclab/mapknitter/builds/520554195

jywarren · 2019-04-18T17:26:50Z

Thanks, everyone!

jywarren added the help wanted label Feb 19, 2019

sashadev-sky mentioned this issue Feb 23, 2019

Upgrade to mySQL5.7, Ruby warning reductions, .md file updates #355

Merged

3 tasks

sashadev-sky mentioned this issue Mar 5, 2019

Restructure rake test task runner #380

Merged

6 tasks

sashadev-sky mentioned this issue Apr 3, 2019

Upgrade from Rails 3.2 to Rails 4.2.8 #481

Closed

jywarren closed this as completed Apr 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reduce Ruby warnings in recent builds #345

Reduce Ruby warnings in recent builds #345

jywarren commented Feb 19, 2019

jywarren commented Feb 19, 2019

grvsachdeva commented Feb 20, 2019 •

edited

Loading

sashadev-sky commented Feb 21, 2019

sashadev-sky commented Mar 27, 2019 •

edited

Loading

sashadev-sky commented Mar 27, 2019 •

edited

Loading

jywarren commented Mar 30, 2019 via email

kaustubh-nair commented Mar 30, 2019 •

edited

Loading

alaxalves commented Apr 2, 2019 •

edited

Loading

jywarren commented Apr 2, 2019 via email

sashadev-sky commented Apr 3, 2019 •

edited

Loading

alaxalves commented Apr 3, 2019

jywarren commented Apr 18, 2019

jywarren commented Apr 18, 2019

jywarren commented Apr 18, 2019

Reduce Ruby warnings in recent builds #345

Reduce Ruby warnings in recent builds #345

Comments

jywarren commented Feb 19, 2019

jywarren commented Feb 19, 2019

grvsachdeva commented Feb 20, 2019 • edited Loading

sashadev-sky commented Feb 21, 2019

sashadev-sky commented Mar 27, 2019 • edited Loading

sashadev-sky commented Mar 27, 2019 • edited Loading

jywarren commented Mar 30, 2019 via email

kaustubh-nair commented Mar 30, 2019 • edited Loading

alaxalves commented Apr 2, 2019 • edited Loading

jywarren commented Apr 2, 2019 via email

sashadev-sky commented Apr 3, 2019 • edited Loading

alaxalves commented Apr 3, 2019

jywarren commented Apr 18, 2019

jywarren commented Apr 18, 2019

jywarren commented Apr 18, 2019

grvsachdeva commented Feb 20, 2019 •

edited

Loading

sashadev-sky commented Mar 27, 2019 •

edited

Loading

sashadev-sky commented Mar 27, 2019 •

edited

Loading

kaustubh-nair commented Mar 30, 2019 •

edited

Loading

alaxalves commented Apr 2, 2019 •

edited

Loading

sashadev-sky commented Apr 3, 2019 •

edited

Loading