-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add loadbalancer rake task #219
base: main
Are you sure you want to change the base?
Conversation
add two tasks: one that allow us to remove an endpoint from serving to the loadbalancer another that will put it back on the loadbalancer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @kayiwa. I think you will need to do a bundle update --conservative health-monitor-rails
for this code to work.
There's actually a breaking change for Rails 7.2 in the 12.4.1 release, so you have to pin to release 12.4.0. You need to change the line in Gemfile for health-monitor-rails to |
f6b7ac5
to
680003a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Francis! Couple small changes.
Co-authored-by: Max Kadel <[email protected]>
Co-authored-by: Max Kadel <[email protected]>
Co-authored-by: Max Kadel <[email protected]>
5408258
to
67bd739
Compare
add two tasks:
one that allow us to remove an endpoint from serving to the
loadbalancer
another that will put it back on the loadbalancer
closes #218