Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add loadbalancer rake task #219

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

add loadbalancer rake task #219

wants to merge 5 commits into from

Conversation

kayiwa
Copy link
Member

@kayiwa kayiwa commented Nov 12, 2024

add two tasks:
one that allow us to remove an endpoint from serving to the
loadbalancer
another that will put it back on the loadbalancer

closes #218

add two tasks:
one that allow us to remove an endpoint from serving to the
loadbalancer
another that will put it back on the loadbalancer
@coveralls
Copy link

coveralls commented Nov 12, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling 67bd739 on i218_loadbalancer_rake
into acb1913 on main.

Copy link
Member

@carolyncole carolyncole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kayiwa. I think you will need to do a bundle update --conservative health-monitor-rails for this code to work.

@maxkadel
Copy link

There's actually a breaking change for Rails 7.2 in the 12.4.1 release, so you have to pin to release 12.4.0. You need to change the line in Gemfile for health-monitor-rails to gem 'health-monitor-rails', '12.4.0'

Copy link

@maxkadel maxkadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Francis! Couple small changes.

config/initializers/health_monitor.rb Outdated Show resolved Hide resolved
config/deploy.rb Outdated Show resolved Hide resolved
config/deploy.rb Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Capistrano task to remove application from the load balancer
4 participants