Dedup tests

[acozine]

First attempt / first steps toward streamlining Molecule tests as discussed in #2685.

This branch uses the openjdk role as a test case, because it's small, has only one dependency, and is used in several playbooks. This branch:

• removes the dependency on the common role from the openjdk/meta/main.yml file
• explicitly adds the common role to every playbook that calls the openjdk role
• explicitly adds the common role to the tests for the openjdk role

[acozine]

Note to Future Me:
The openjdk role listed a dependency on common.
The saxon role listed a dependency on openjdk, with no other depedencies.
When I deleted the dependency in the openjdk role, the saxon role tests failed with a missing package failure.

I'm betting this means that the saxon tests need to run the common role, and did not. So I've added a dependency on common to the saxon role (and also to the zookeeper role, which had the same single dependency on openjdk). If both pass CI, I will understand more about how all this fits together.

[acozine]

I updated the ADR to reflect the agreement we would be making if/when we merge this PR. The change is still under discussion, though!

[acozine]

@carolyncole is concerned about the maintenance burden in playbooks, and specifically about the possibility of drift between staging and production playbooks. This led to a conversation about the way the repo currently handles groups in the hosts file, group_vars, role variables, and playbooks. Can we have a single playbook per project, with both the target hosts and the variables determined at runtime (for example, something like ansible-playbook playbooks/pulmap.yml -e env=prod and ansible-playbook playbooks/pulmap.yml -e env=staging instead of separate playbooks pulmap_production.yml and pulmap_staging.yml? This would reduce both maintenance and drift.

[hackartisan]

providing the stage at playbook runtime seems fine to me.

[acozine]

Recent changes to our CI have made improvements to this problem - see https://github.com/pulibrary/princeton_ansible/runs/6040136600?check_suite_focus=true for a run in which the common role was NOT run multiple times!!!

[hackartisan]

Recent changes to our CI have made improvements to this problem

What were the changes?