floogen: Use unique IDs for endpoints #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fischeti
force-pushed
the
unique-id
branch
3 times, most recently
from
8d494bd
to
a2e10e7
Compare
An ID offset is only needed for XY Routing
fischeti
changed the title
fischeti
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the unique ID was restricted to the
SourceRoutingandIdTablerouting algorithm, since it is actually required for routing. TheXYRoutingalgorithm used XY coordinates instead.However, FlooGen creates a SV enum of all endpoints, for which a unique ID is necessary independent of the routing algorithm.
Also fixes the alphanumeric ordering of the endpoints enum.