Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CONTRIBUTING] ✏️ remove redundant commit message emoji #272

Closed
wants to merge 2 commits into from
Closed

[CONTRIBUTING] ✏️ remove redundant commit message emoji #272

wants to merge 2 commits into from

Conversation

fischeti
Copy link

Remove redundant commit message emoji

Changelog

Fixed

  • Redundant Fire emoji in CONTRIBUTING.md

Checklist

  • Automated tests pass
  • Changelog updated
  • Code style guideline is observed

Please check our contributing guidelines before opening a Pull Request.

@fischeti fischeti requested a review from mp-17 December 12, 2023 10:08
mp-17
mp-17 requested changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@mp-17 mp-17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, Tim! I have only one comment: can you please remove the first one instead of the second one, as the second one contains more information?

CONTRIBUTING.md Outdated
@@ -37,7 +37,6 @@ please find some of the most important points below.
* :fire: `:fire` Removing code or files.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this one ^

CONTRIBUTING.md
@@ -37,7 +37,6 @@ please find some of the most important points below.
* :fire: `:fire` Removing code or files.
* :memo: `:memo:` When writing docs
* :bug: `:bug:` When fixing a bug
* :fire: `:fire:` When removing code or files
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And keep this one instead ^

fischeti
fischeti commented Dec 12, 2023
View reviewed changes
Copy link
Author

@fischeti fischeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, Tim! I have only one comment: can you please remove the first one instead of the second one, as the second one contains more information?

I have an even better solution 🚀

@fischeti fischeti closed this Dec 12, 2023
@fischeti fischeti mentioned this pull request Jun 5, 2024
Merged
@mp-17
Copy link
Collaborator

mp-17 commented Jun 5, 2024

Please merge this PR first pulp-platform/snitch_cluster#149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp-17 mp-17 mp-17 requested changes

@suehtamacv suehtamacv Awaiting requested review from suehtamacv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fischeti @mp-17