Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vivado xsim : add XILINX_SIMULATOR ifdefs replace XSIM ifdef #264

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

skokvermon
Copy link
Contributor

replace XSIM ifdef by XILINX_SIMULATOR as described in https://docs.xilinx.com/r/en-US/ug900-vivado-logic-simulation/Predefined-Macros
depends on pulp-platform/common_cells#139

Some more benchs are working

However there are segfaults on a lot of them.

@skokvermon skokvermon mentioned this pull request Sep 27, 2022
@thommythomaso
Copy link
Collaborator

We have internally discussed this matter. We can change XSIM to XILINX_SIMULATOR and guard/implement alternatives to make the TBs work in xsim if:

  • the changes happening globally and in the dependencies first, e.g., change XSIM to XILINX_SIMULATOR in common_cells first
  • the testbenches (or most of them) do run
  • the target is for sure not used in fusesoc for a different purpose (as XSIMwas introduced by olofk)
  • the code of the testbench will not look too fragmented due to too many ifdefs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants