Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MemPool DMA and ITA as Peripheral #8

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Implement MemPool DMA and ITA as Peripheral #8

merged 2 commits into from
Oct 11, 2023

Conversation

Xeratec
Copy link
Contributor

@Xeratec Xeratec commented Oct 10, 2023

This pull request implements MemPool's DMA and ITA as a peripheral. The code is based on Samuel's version in the Snitch repository, with additional modifications to ITA. These modifications, enables reconfigurable re-quantization parameter via the cluster level CSRs.

Added

  • Implemented MemPool ITA as peripheral
  • Implemented MemPool DMA as peripheral
  • Added binary_memcpy function

Changes

  • Changed binary_load and binary_store to public functions
  • Pass cpu to peripheral load and store functions
  • Updated mempool.yaml to include ITA and DMA

@Xeratec
[fix] Fix CI
45e7a44 
- Run rustfmt
- Fix regex version to be compatible with rustc 1.63.0
SamuelRiedel
SamuelRiedel approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@SamuelRiedel SamuelRiedel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@SamuelRiedel SamuelRiedel merged commit 2be5628 into pulp-platform:main Oct 11, 2023
2 checks passed
@Xeratec Xeratec deleted the pr/ita branch October 12, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelRiedel SamuelRiedel SamuelRiedel approved these changes

@viv-eth viv-eth Awaiting requested review from viv-eth viv-eth is a code owner

@paulsc96 paulsc96 Awaiting requested review from paulsc96 paulsc96 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xeratec @SamuelRiedel