Add mem_to_banks_detailed
#194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds sideband data in the response path to be managed externally. `mem_to_banks` now wraps the `mem_to_banks_detailed`.
niwis
reviewed
Jul 31, 2023
There was a problem hiding this comment.
Thanks, LGTM in general. Could you also add the new module in src_files.yml and common_cells.core (plus a brief description in the README)?
glaserf
reviewed
Aug 2, 2023
There was a problem hiding this comment.
I second what @niwis has said. Looks good to me.
One suggestion would be to generalize the error-response channel to generic side-channel memory response info by renaming it accordingly, but I'm not sure whether such use cases (besides error responses) do exist.
`atop` renamed to `wuser` `ersp` renamed to `ruser`
|
The updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds sideband data in the response path to be managed externally.
mem_to_banksnow wraps themem_to_banks_detailed.