mem_to_banks_detailed: Ensure no spurious response after full dead write
#224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niwis
reviewed
Jul 18, 2024
There was a problem hiding this comment.
@micprog thanks for the contribution! Three points from my side:
- Masking
dead_responsewith~dead_write_fifo_emptymakes sense to me. - Is the reduction (lines 156, 159, 161) really necessary?
- Why do we need to change the input of the
dead_read_fifofrombank_ouptobank_req?
|
As discussed in person, 3. is necessary to align the |
niwis
approved these changes
Jul 18, 2024
niwis
force-pushed
the
michaero/fix_memtobanks_deadwrite
branch
from
fa8f9c7
to
d213808
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.