Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inverted reset in delta_counter #242

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Fix inverted reset in delta_counter #242

merged 1 commit into from
Oct 9, 2024

Conversation

olofk
Copy link
Contributor

@olofk olofk commented Oct 9, 2024

A recent fix to the reset logic in delta_counter 10dac0f looks like it accidentally inverted the reset logic.

niwis
niwis reviewed Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@niwis niwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @olofk, great catch! Just one nitpick: could you use the logical negation operator instead? i.e. !rst_ni

@olofk
Copy link
Contributor Author

olofk commented Oct 9, 2024

Better now?

FrancescoConti
FrancescoConti approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@FrancescoConti FrancescoConti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

niwis
niwis approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@niwis niwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep ,thanks a lot!

@niwis niwis merged commit 554ebbc into pulp-platform:master Oct 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrancescoConti FrancescoConti FrancescoConti approved these changes

@niwis niwis niwis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olofk @niwis @FrancescoConti