Add OS support to Ara #61
Draft
+362
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions with side effects flush the unissued instructions from the controller. The accelerator dispatcher buffer is flushed when this happens and avoids accepting a new instruction, but was not preventing the actual issue during a flush cycle.
|
Thank you, @mp-17, for this! I think it would make sense to split these changes into separate PRs upstream to avoid maintaining them out-of-tree. Especially the bug fixes should be upstreamed. If there are any issues with merging specific changes (e.g. the MMU interface), we can still consider doing this here. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve bug in
acc_dispatcherDon't mark vector instructions as "non-speculative" when flushing in the same cycle. Indeed, instructions with side effects flush the unissued instructions from the controller. The accelerator dispatcher buffer is flushed when this happens and avoids accepting a new instruction, but it does not prevent the actual issue during a flush cycle.
Solve non-propagated exception bug:
The exception from the vector accelerator is now correctly propagated to CVA6 backend for commit.
Add MMU interface for accelerator:
CVA6 can now share its MMU with the vector accelerator with a simple FSM and multiplexer.
Extend the instruction tracer to ease debugging:
Add initial support for VLD/VST to CVA6 tracer.
Update signal labels:
Update the nomenclature of the CVA6-Ara interface signals.