Use a customized version of QueryExistingArtifacts #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubosmj
force-pushed
the
performance-imp-check-1
branch
from
7e39af1 to
3def33a
Compare
lubosmj
force-pushed
the
performance-imp-check-1
branch
from
3def33a to
6cf6404
Compare
In this change, the stage is comparing only sha256 digests between existing and newly added artifacts. Furthermore, the time complexity for the old comparison was O(N^2). With the attached change, we work with O(2N). closes pulp#289
lubosmj
force-pushed
the
performance-imp-check-1
branch
from
6cf6404 to
42cba31
Compare
dkliban
approved these changes
Nov 16, 2023
Backport to 2.2: 💚 backport PR created✅ Backport PR branch: Backported as #314 🤖 @patchback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this change, the stage is comparing only sha256 digests between existing and newly added artifacts. Furthermore, the time complexity for the old comparison was O(N^2). With the change, we work with O(2N).
closes #289