Prepare to migrate to the new versioning system - part 2

.github/workflows/ci-standards.yml

@@ -15,7 +15,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [16.x]
+        node-version: [18.x]
 
     steps:
     - name: Checkout the latest code

.github/workflows/ci-tests-pull.yml

@@ -39,7 +39,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [16.x]
+        node-version: [17.x, 18.x, 19.x]
 
     steps:
     - name: Checkout the latest code

.github/workflows/ci-tests.yml

@@ -42,7 +42,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [16.x]
+        node-version: [17.x, 18.x, 19.x]
 
     steps:
       - name: Checkout the latest code

.nvmrc

@@ -0,0 +1 @@
+18

app.example.yaml

@@ -2,7 +2,7 @@
 # Name this file app.yaml, and it will be picked up by the server.
 # app.yaml is in the git ignore to prevent any secrets from leaking.
 
-runtime: nodejs14
+runtime: nodejs18
 service: default
 
 env_variables:
@@ -22,8 +22,6 @@ env_variables:
   GH_CLIENTID: ""
   # The Client Secret to accompany the CLIENT ID
   GH_CLIENTSECRET: ""
-  # The github username associated with the token.
-  GH_USERNAME: ""
   # The User Agent thats used to communicate with GitHub
   GH_USERAGENT: "Pulsar-Edit Bot"
   # The URI that the OAuth instance should redirect to. Should end in `/api/oauth`
@@ -48,3 +46,5 @@ env_variables:
   # Determines how Logs are written. Currently supports the following options:
   # stdout - Writes the console
   LOG_FORMAT: "stdout"
+  RATE_LIMIT_GENERIC: 300
+  RATE_LIMIT_AUTH: 300

package.json

@@ -4,7 +4,7 @@
   "description": "The Pulsar API Backend for the Community fork of Atom.",
   "main": "src/server.js",
   "engines": {
-    "node": ">=14.0.0 <=16.16.0"
+    "node": ">=17.9.1 <=18.13.0"
   },
   "scripts": {
     "start": "node ./src/server.js",

scripts/database/create_names_table.sql

@@ -4,10 +4,26 @@
 
 CREATE TABLE names (
     name VARCHAR(128) NOT NULL PRIMARY KEY,
-    pointer UUID NOT NULL REFERENCES packages(pointer),
+    pointer UUID NULL,
     -- constraints
-    CONSTRAINT lowercase_names CHECK (name = LOWER(name))
+    CONSTRAINT lowercase_names CHECK (name = LOWER(name)),
+    CONSTRAINT package_names_fkey FOREIGN KEY (pointer) REFERENCES packages(pointer) ON DELETE SET NULL
 );
 
 -- Lowercase constraint added upon the following issue:
 -- https://github.com/confused-Techie/atom-backend/issues/90
+
+/*
+-- `pointer` was NOT NULL, then we made it nullable.
+-- The previous foreign key has been dropped and a new `package_names_fkey`
+-- has need added to avoid supply chain attacks.
+-- `pointer` is set to NULL when a row in packages table is deleted.
+-- Steps made to apply this change:
+
+ALTER TABLE names ALTER COLUMN pointer DROP NOT NULL;
+
+ALTER TABLE names DROP CONSTRAINT previous_foreign_key_name;
+
+ALTER TABLE names
+ADD CONSTRAINT package_names_fkey FOREIGN KEY (pointer) REFERENCES packages(pointer) ON DELETE SET NULL;
+*/

scripts/database/create_versions_table.sql

@@ -11,7 +11,10 @@ CREATE TABLE versions (
     semver VARCHAR(256) NOT NULL,
     license VARCHAR(128) NOT NULL,
     engine JSONB NOT NULL,
+    created TIMESTAMP WITH TIME ZONE NOT NULL DEFAULT CURRENT_TIMESTAMP,
+    updated TIMESTAMP WITH TIME ZONE NOT NULL DEFAULT CURRENT_TIMESTAMP,
     meta JSONB,
+    deleted BOOLEAN NOT NULL DEFAULT FALSE,
     -- generated columns
     semver_v1 INTEGER GENERATED ALWAYS AS
         (CAST ((regexp_match(semver, '^(\d+)\.(\d+)\.(\d+)'))[1] AS INTEGER)) STORED,
@@ -21,5 +24,15 @@ CREATE TABLE versions (
         (CAST ((regexp_match(semver, '^(\d+)\.(\d+)\.(\d+)'))[3] AS INTEGER)) STORED,
     -- constraints
     CONSTRAINT semver2_format CHECK (semver ~ '^\d+\.\d+\.\d+'),
-    CONSTRAINT unique_pack_version UNIQUE(package, semver_v1, semver_v2, semver_v3)
+    CONSTRAINT unique_pack_version UNIQUE(package, semver)
 );
+
+-- Create a function and a trigger to set the current timestamp
+-- in the `updated` column of the updated row.
+-- The function now_on_updated_package() is the same defined in
+-- the script for the `packages` table.
+
+CREATE TRIGGER trigger_now_on_updated_versions
+    BEFORE UPDATE ON versions
+    FOR EACH ROW
+EXECUTE PROCEDURE now_on_updated_package();