Fix naive iteration of service listing #128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My original stab at this in #125 wasn't paranoid enough. After all, we're reading from a random
package.json
file, and there's no guarantee that the format of that file will be what we expect.In this case, the
atom-ide-deno
package detail page was 500ing because of this apparent nesting error in the JSON.The fix is to do poor-man's validation of the JSON as we're consuming it, bailing if anything isn't what we expect.
Verification
https://web.pulsar-edit.dev/packages/atom-ide-deno will fail on
main
; http://localhost:8091/packages/atom-ide-deno will succeed when run locally on this PR branch.