Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[image-view] Add scroll support to zoom-in and zoom-out #1197

Open
wants to merge 4 commits into
base: updated-latest-electron
Choose a base branch
from

Conversation

asiloisad
Copy link
Contributor

It's natural to zoom-in and zoom-out images by Ctrl-Scroll. It was required to change how zoom-to-fit works.

@confused-Techie
Copy link
Member

confused-Techie commented Jan 16, 2025

Really excited about this feature idea, and something I've absent-mindedly tried to do way to many times forgetting it doesn't exist.

But I do see some test failures here, that I don't necessarily believe are the fault of your code at all, but are ones we don't expect to see, so we will probably want to take a closer look at those sometime soon.

@DeeDeeG a ping for whenever your available if you'd like to help look into this.


EDIT:

Sorry, I missed this was aimed at updated-latest-electron, which most certainly may be the reason we are seeing the failures.

If you intended to target the dev electron branch, feel free to ignore my above comment. But if you otherwise think this is something that can work now, which seems to me like it could, maybe you can retarget to the master branch and we can merge it for the rolling releases now, and ideally our CI will be much happier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants