[core] Stop handling beta, nightly
#922
Conversation
|
I assume the rest of the code that referenced nightly and beta was in the auto update code that we pruned a while ago. |
|
Ahh @Daeraxa you are probably right there, so makes sense why there was so little still referencing it |
| // Public: Returns a {Boolean} that is `true` if the current version is an official release. | ||
| isReleasedVersion() { | ||
| return this.getReleaseChannel().match(/stable|beta|nightly/) != null; | ||
| return this.getReleaseChannel().match(/stable|dev/) != null; | ||
| } |
There was a problem hiding this comment.
I dunno, you can build Pulsar locally without changing the version string in package.json from e.g. 1.113.0-dev. I don't generally think -dev versions are "Released Versions"... Right?
| getCommandNameForChannel(commandName) { | ||
| let channelMatch = this.appVersion.match(/beta|nightly/); | ||
| let channelMatch = this.appVersion.match(/dev/); | ||
| let channel = channelMatch ? channelMatch[0] : ''; | ||
|
|
||
| switch (channel) { | ||
| case 'beta': | ||
| return `${commandName}-beta`; | ||
| case 'nightly': | ||
| return `${commandName}-nightly`; | ||
| case 'dev': | ||
| return `${commandName}-dev`; | ||
| default: | ||
| return commandName; | ||
| } |
There was a problem hiding this comment.
Is there a situation where Pulsar can be launched with the CLI command name pulsar-dev?
Otherwise, I think we might just need to reduce this function's body to simply return commandName...
|
@DeeDeeG You are absolutely correct, in that the changes adding I thought it'd be akin to |
|
I reckon that, coincidentally for each of these separately, it makes the most sense to remove (Tangent: If we do remove handling for |
|
FWIW I don't see us using
But by and large these functions are both kind of obsolete without there being the full-on "release channels" concept supported by us anymore, where we flavor/style the app based on the channel name. |
I think that function was entirely used internally via the update scripts previously. I don't think there's any use for it outside of that
Could probably just give it the Grim deprecate treatment and remove it in a version or two? (Since there are larger problems with the way that Atom was set up to be a 1.y.z-only application we can't ever do a true Semver major) |
|
We could put a |
|
I'd be willing to push changes to the branch simplifying the functions as per above feedback if that would be okay, at which point I believe this would be ready to merge IMO. EDIT: This assuming no objections from other reviewers either of course. |
|
@DeeDeeG If you have the time to push changes to get this one ready to go that would be totally fine by me, and I'd appreciate it! |
This PR ended up being much simpler than expected.
But it's goal was remove any explicit handling of
betaornightlyfor Pulsar in reference to release channels.Since Pulsar has not used that nomenclature for over a year, it seemed past due time.
In it's place, I have added
dev, since for our dev instance of Pulsar that is what it's currently recognized as, which makes sense since that version is only accessible when literally in dev mode.What may be worth mentioning is this change doesn't address the already non-existent distinction between
rollingandregularrelease channels. But that wasn't handled previously so this is no change in that respect. Here we just remove what's become useless code.