Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use group ID and not display name on remove #238

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

fcharlaix-opendsi
Copy link
Contributor

In the login service, group display name and ID are mixed, causing users to be removed and added to the same group when a display name is set.

This problem sends notifications to the user (if enabled) and remove external storage on the desktop client (if external storage are disabled when added, the default behavior in the desktop client configuration).

@pulsejet pulsejet merged commit 7b708d4 into pulsejet:master Aug 30, 2023
2 checks passed
@pulsejet
Copy link
Owner

pulsejet commented Aug 30, 2023

Hmm this isn't super intuitive since it makes impossible to rename groups. Perhaps it might make more sense to exclusively use the display name of the group over the GID

EDIT: the fundamental issue is that the GID isn't very obvious, e.g. in the admin panel unless you look at the URL

EDIT 2: on second thoughts, probably sticking to GID is the best and document this instead.

@pulsejet
Copy link
Owner

Pls ignore the false alarm. Should be good with 092c223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants