Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle POSTLogout issue to resolve deleting account on SSO #273

Merged
merged 7 commits into from
Apr 15, 2024

Conversation

theronakpatel
Copy link
Contributor

No description provided.

@theronakpatel
Copy link
Contributor Author

theronakpatel commented Apr 10, 2024

Resolving: #272

NOTE: The issue comes only when using the delete functionality from the app drop_account.

Error message on UI when deleting account logged in using SSO at murena.io

  • The issue is PostLogin listener is redirecting the execution for API call. So that is why it returns Network error as I mentioned in the ticket. So to resolve this, we should not redirect when there is an API call.

  • The issue is currently working as expected in the my local setup.

  • Steps to test:

    • Login using oidc
    • Go to settings > drop account
    • Now, when you try to delete it, it will work now.

@theronakpatel theronakpatel changed the title handle postlogout issue to resolve deleting account on SSO handle POSTLogout issue to resolve deleting account on SSO Apr 10, 2024
Copy link
Owner

@pulsejet pulsejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it's better to check for XHR explicitly?
https://stackoverflow.com/questions/18260537/how-to-check-if-the-request-is-an-ajax-request-with-php

Also please fix the indentation to use spaces (see the files changed tab)

@theronakpatel
Copy link
Contributor Author

@pulsejet I tried this solution , but it does not work, so I reverted back.

@ronakpp
Copy link

ronakpp commented Apr 15, 2024

@pulsejet Can you test at your side too if possible and approve if all looks good.

@pulsejet
Copy link
Owner

LGTM, thanks

@pulsejet pulsejet merged commit 888f162 into pulsejet:master Apr 15, 2024
2 checks passed
@ronakpp
Copy link

ronakpp commented Apr 16, 2024

@pulsejet What is the expected date of new release with this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants