-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update blog template #11881
Update blog template #11881
Conversation
Your site preview for commit 308880b is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-11881-308880b3.s3-website.us-west-2.amazonaws.com. |
archetypes/blog-post/index.md
Outdated
social_twitter: "social copy to post on Twitter" | ||
social_linkedin: "social copy to post on Linkedin" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also do this:
social_twitter: "social copy to post on Twitter" | |
social_linkedin: "social copy to post on Linkedin" | |
social: | |
twitter: | |
linkedin: |
... And then leave these blank, as we do with the meta_desc. (I just wonder whether people will look right past it otherwise.)
This is true, but we could also fix this by backfilling with placeholder data, and lint going forward. I just worry that by not linting, we'll essentially in the same position we're in today, having to nag people to do it after the fact. |
# The social copy used to promote this post on Twitter and Linkedin. These | ||
# properties do not actually create the post and have no effect on the | ||
# generated blog page. They are here strictly for reference. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
People almost always ask for "good" examples of both of these (as each service has its own sort of "idiom") to give them have something to model their own copy by. It might be good to provide a couple of links here in the comments to help with that. Here are a few shared with me recently (when I asked for my last post):
- https://www.linkedin.com/feed/update/urn:li:activity:7171191945841561601
- https://www.linkedin.com/feed/update/urn:li:activity:7169021002394296320
- https://www.linkedin.com/feed/update/urn:li:activity:7155606616455737345
- https://twitter.com/PulumiCorp/status/1763265391042654623
- https://twitter.com/PulumiCorp/status/1762900472489185492
- https://twitter.com/PulumiCorp/status/1755637618631405655
Your site preview for commit 83035e6 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-11881-83035e69.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit fd8abff is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-11881-fd8abff9.s3-website.us-west-2.amazonaws.com. |
thanks @cnunciato! I made updates to the structure and comments. I'll follow on with adding linting around this and also backfill the existing posts. |
Updates the blog template to include properties to house the social copies to be posted on twitter and linkedin. I also updated the
disabledKinds
config to update it totaxonomyTerm
fromtaxonomy
. This term was updated to this after hugo 0.73 from my understanding and also matches the config we were running in pulumi-hugo. I also added thecategory
kind as well, since pulumi-hugo had this listed. It was giving me an error before I updated this when running thehugo new
command to generate the blog files.We could add linting here to enforce this, but it would fail unless we add these props to all the blog files. It also will presumably just pass for new blog posts going forward as these would already be filled out when generated from the template. Maybe we can do something like only running linting against newly added files in the commit, but I think this should be good enough for now.