Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new 'Compare to' section under ESC in docs #11934

Merged
merged 9 commits into from
Aug 14, 2024
Merged

Conversation

shughes26
Copy link
Contributor

@shughes26 shughes26 commented May 31, 2024

Proposed changes

Added new Compare to directory under ESC in docs, and page for ESC vs Vault
https://github.com/pulumi/marketing/issues/1060

@pulumi-bot
Copy link
Collaborator

Copy link
Contributor

@aaronkao aaronkao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushing through some changes here

content/docs/esc/vs/vault.md Outdated Show resolved Hide resolved
content/docs/esc/vs/vault.md Outdated Show resolved Hide resolved
content/docs/esc/vs/_index.md Outdated Show resolved Hide resolved
content/docs/esc/vs/_index.md Outdated Show resolved Hide resolved
content/docs/esc/vs/_index.md Outdated Show resolved Hide resolved
content/docs/esc/vs/_index.md Outdated Show resolved Hide resolved
@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@arunkumar611
Copy link
Member

We should change the get started here at the bottom of the page. It is talking about IaC:

image

@pulumi-bot
Copy link
Collaborator

Your site preview for commit cb7b7b1a is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-11934-cb7b7b1a.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@shughes26 shughes26 marked this pull request as ready for review June 4, 2024 21:11
* update comparision

* Update content/docs/esc/vs/infisical.md

* Edits

* Some small edits

* Differences paragraph edits

---------

Co-authored-by: Aaron Kao <[email protected]>
@pulumi-bot
Copy link
Collaborator

@aaronkao aaronkao requested a review from a team as a code owner August 14, 2024 20:57
@pulumi-bot
Copy link
Collaborator

@shughes26 shughes26 merged commit 5825b7d into master Aug 14, 2024
7 checks passed
@shughes26 shughes26 deleted the sarah/esc-vs-vault branch August 14, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants