Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superfluous package authoring page. #12453

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

jkodroff
Copy link
Member

@jkodroff jkodroff commented Aug 5, 2024

Proposed changes

Unreleased product version (optional)

Related issues (optional)

@jkodroff jkodroff requested a review from a team as a code owner August 5, 2024 21:31
@pulumi-bot
Copy link
Collaborator

@jkodroff
Copy link
Member Author

@pulumi/docs Still waiting on a review on this. Note that the main registry page links to the page I want to remove: https://www.pulumi.com/registry/

Do I need to fix that somewhere else?

Copy link
Member

@sean1588 sean1588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving my approval here as this makes sense to me. I'm not part of the docs team github group so not sure if you will need to wait for a review from one of them.

@sean1588
Copy link
Member

Do I need to fix that somewhere else?

@jkodroff - I opened a PR to update registry here: pulumi/registry#5258

I also pushed a commit to this PR to redirect from the deleted page roure

@pulumi-bot
Copy link
Collaborator

Copy link
Collaborator

@interurban interurban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx Josh

@jkodroff jkodroff merged commit 6c0e9ef into master Aug 26, 2024
7 checks passed
@jkodroff jkodroff deleted the jkodroff/remove-old-package-authoring branch August 26, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants