Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Kubernetes await logic blog post #12454

Merged
merged 9 commits into from
Sep 4, 2024
Merged

Improved Kubernetes await logic blog post #12454

merged 9 commits into from
Sep 4, 2024

Conversation

blampe
Copy link
Contributor

@blampe blampe commented Aug 5, 2024

This post includes an overview of upcoming improvements to await logic in the Kubernetes provider.

Note that some of these changes are still in review, so this should not be published until they've been released.

@pulumi-bot
Copy link
Collaborator

@mjeffryes mjeffryes added this to the 0.108 milestone Aug 16, 2024
@mikhailshilkov mikhailshilkov modified the milestones: 0.108, 0.109 Aug 22, 2024
@pulumi-bot
Copy link
Collaborator

Copy link
Member

@mjeffryes mjeffryes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks solid to me. Clear description of the changes with examples, and why they matter to users. All anchored in the core value prop of using pulumi for K8s.

content/blog/improved-kubernetes-await-logic/index.md Outdated Show resolved Hide resolved
@pulumi-bot
Copy link
Collaborator

content/blog/improved-kubernetes-await-logic/index.md Outdated Show resolved Hide resolved
content/blog/improved-kubernetes-await-logic/index.md Outdated Show resolved Hide resolved
content/blog/improved-kubernetes-await-logic/index.md Outdated Show resolved Hide resolved
Using `skipAwait` to speed up deletion is not recommended when server-side apply is enabled because it is not respected by all resources and it can lead to race conditions during replacement.
The current behavior is considered buggy, and future releases might change the behavior of the `skipAwait` annotation to have no effect during deletion.

The `pulumi.com/deletionPropagationPolicy` annotation is the recommended way to delete something quickly and safely.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this advice because they're not analogues. You're implying that deletionPropagationPolicy would make the cleanup of the managed resource be quicker, which I suppose would be true if the object has children that are slow to cleanup.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly! Changed this to include "...if it has children that are slow to cleanup."

## Experimental: Custom readiness with "pulumi.com/waitFor"

{{% notes type="info" %}}
The `pulumi.com/waitFor` annotation is considered experimental and its syntax may change in the future.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next time we could adopt the Kubernetes convention of using .alpha. in the annotation's name, for experimental stuff. For example: external-dns.alpha.kubernetes.io/ttl.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great point!

content/blog/improved-kubernetes-await-logic/index.md Outdated Show resolved Hide resolved
content/blog/improved-kubernetes-await-logic/index.md Outdated Show resolved Hide resolved
content/blog/improved-kubernetes-await-logic/index.md Outdated Show resolved Hide resolved
content/blog/improved-kubernetes-await-logic/index.md Outdated Show resolved Hide resolved
content/blog/improved-kubernetes-await-logic/index.md Outdated Show resolved Hide resolved
@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@blampe blampe requested a review from meagancojocar September 4, 2024 16:40
@blampe blampe merged commit 6fee382 into master Sep 4, 2024
10 checks passed
@blampe blampe deleted the blampe/k8s-await branch September 4, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants