-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Kubernetes await logic blog post #12454
Conversation
Your site preview for commit b2553e2 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-12454-b2553e22.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit dd7c198 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-12454-dd7c1985.s3-website.us-west-2.amazonaws.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks solid to me. Clear description of the changes with examples, and why they matter to users. All anchored in the core value prop of using pulumi for K8s.
Your site preview for commit 11c2415 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-12454-11c2415d.s3-website.us-west-2.amazonaws.com. |
Using `skipAwait` to speed up deletion is not recommended when server-side apply is enabled because it is not respected by all resources and it can lead to race conditions during replacement. | ||
The current behavior is considered buggy, and future releases might change the behavior of the `skipAwait` annotation to have no effect during deletion. | ||
|
||
The `pulumi.com/deletionPropagationPolicy` annotation is the recommended way to delete something quickly and safely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this advice because they're not analogues. You're implying that deletionPropagationPolicy would make the cleanup of the managed resource be quicker, which I suppose would be true if the object has children that are slow to cleanup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly! Changed this to include "...if it has children that are slow to cleanup."
## Experimental: Custom readiness with "pulumi.com/waitFor" | ||
|
||
{{% notes type="info" %}} | ||
The `pulumi.com/waitFor` annotation is considered experimental and its syntax may change in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next time we could adopt the Kubernetes convention of using .alpha.
in the annotation's name, for experimental stuff. For example: external-dns.alpha.kubernetes.io/ttl
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great point!
Co-authored-by: Eron Wright <[email protected]>
Your site preview for commit 70176a4 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-12454-70176a47.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit e478aab is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-12454-e478aab5.s3-website.us-west-2.amazonaws.com. |
This post includes an overview of upcoming improvements to await logic in the Kubernetes provider.
Note that some of these changes are still in review, so this should not be published until they've been released.