-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Managing Configuration and Secrets Tutorial #12530
Conversation
Your site preview for commit efa6eba is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-12530-efa6ebab.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit 819e070 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-12530-819e0703.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit 047c254 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-12530-047c254e.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit 7083bb8 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-12530-7083bb8a.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit 324509a is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-12530-324509ac.s3-website.us-west-2.amazonaws.com. |
# - some-non-existent-collection | ||
--- | ||
|
||
## Create a new project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the "Inspecting Infrastructure" tutorial, we refer to this step as optional (e.g. either use an existing project or create a new one). That said, tagging this as optional in that tutorial, especially as the first step, felt a little awkward. I think we should be consistent across the tutorials and introduce this step as "Next, either create a new project or navigate to the code for an existing one. To create a project...".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I almost wonder if we should just keep it simple rather than adding the indication that it can be run against existing code. I do agree that the [Optional] part in the other tutorial is a bit awkward so I will remove that on another branch.
|
||
## Create configuration values | ||
|
||
In a Pulumi project, you can locally [store and retrieve configuration values](/docs/concepts/config/) using the `pulumi config set <key> [value]` command. To demonstrate, run the following command to create a configuration value with a key of `myEnvironment` and a value of `development`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment. I think we should use a different example configuration value other than the overloaded term "environment".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On this one I will keep as is. The example program code being leveraged is also being used in another tutorial and I would basically have to duplicate this code just to change myEnvironment
to something else. I have however updated the intro paragraph to make this less confusing. Also I would argue that the use of environment is not specific to Pulumi ESC if we are thinking in terms of dev/test/prod, so in this case I think it's pretty reasonable to have as part of the example.
Your site preview for commit f0b1e6a is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-12530-f0b1e6aa.s3-website.us-west-2.amazonaws.com. |
LGTM! |
Proposed changes
This PR adds the content for the Managing Configuration and Secrets tutorial.