Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESC tutorials: add "Using ESC" collection and fixes some minor nav glitches/typos #12847

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

thoward
Copy link
Contributor

@thoward thoward commented Sep 18, 2024

  • adds a Tutorial collection "Using ESC" / using-esc and places two existing tutorials in it
  • fixes Collection home pages to work with single type layouts vs only working with tutorials with subpages
  • fixes ESC Kubernetes tutorial not showing correct left nav (due to using _index.html vs index.html filename)
  • fixes mismatched descriptions and grammar typos in ESC chatapp tutorial
  • fixes bad link in "More tutorials" section in ESC chatapp tutorial
  • fix for overlapping left nav described in Issue Docs Tutorials - Clickable Cards and Responsiveness of the left nav #12559 (but not the clickable cards part of that issue).
  • fix for breadcrumb nav showing id not display name on Tutorial Collections pages

Screenshot of bad left nav rendering because of _index.html vs index.html:

Screenshot 2024-09-18 at 12 09 27 PM

@thoward thoward requested a review from a team as a code owner September 18, 2024 19:20
@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

Copy link
Collaborator

@interurban interurban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx troy!

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@thoward thoward merged commit 4edb359 into master Sep 20, 2024
6 checks passed
@thoward thoward deleted the thoward/tutorials-navigation branch September 20, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants