Add batching and retry logic to 404 checker #12938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your site preview for commit 087b0c9 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-12938-087b0c9e.s3-website.us-west-2.amazonaws.com. |
cnunciato
approved these changes
Sep 25, 2024
shughes26
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 404 checker has been a bit flaky and causing PRs to error out and also takes about 7 mins to run at the end of the build. I made some adjustments here to check the urls in batch and also added retry logic to make it a bit more resilient to reporting false errors.