Patch to avoid upstream ResourceServer panic #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
iwahbe
reviewed
Sep 15, 2023
|
Thank you I'd also ask for the patch issue to track a bridge issue. TYVM |
mikhailshilkov
force-pushed
the
mikhailshilkov/patch-285
branch
from
365f2ef
to
3e32a8a
Compare
mikhailshilkov
force-pushed
the
mikhailshilkov/patch-285
branch
from
3e32a8a
to
61d9db8
Compare
|
I think I addressed review suggestions - thank you all. I'm not sure why lots of metadata changed - it doesn't look related but I got it from |
EronWright
reviewed
Sep 19, 2023
iwahbe
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #285 by patching the check upsteam
It's my first patch ever, so let me know if I'm doing it wrong.