-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch to avoid upstream ResourceServer panic #298
Conversation
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patch looks good to me. Let's make sure we have a test, both to confirm that the patch works and to make it easy to check when the patch is safe to remove.
Thank you I'd also ask for the patch issue to track a bridge issue. TYVM |
365f2ef
to
3e32a8a
Compare
3e32a8a
to
61d9db8
Compare
I think I addressed review suggestions - thank you all. I'm not sure why lots of metadata changed - it doesn't look related but I got it from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for the metadata stuff, seems to genuinely be losing information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The metadata stuff is just discarding empty objects. We want to include that.
Resolve #285 by patching the check upsteam
It's my first patch ever, so let me know if I'm doing it wrong.