Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS SDK clients for CFN Custom Resource support #1805

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

flostadler
Copy link
Contributor

@flostadler flostadler commented Nov 7, 2024

This change adds the necessary AWS SDK clients (S3 and Lambda) for supporting CFN Custom Resources in aws-native.

Relates to pulumi/pulumi-cdk#109

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@flostadler flostadler self-assigned this Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 70.14218% with 63 lines in your changes missing coverage. Please review.

Project coverage is 46.30%. Comparing base (91e1b65) to head (6575dfa).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
provider/pkg/client/mock_s3.go 65.38% 26 Missing and 1 partial ⚠️
provider/pkg/client/mock_lambda.go 64.58% 16 Missing and 1 partial ⚠️
provider/pkg/client/lambda.go 75.55% 10 Missing and 1 partial ⚠️
provider/pkg/client/s3.go 80.00% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1805      +/-   ##
==========================================
+ Coverage   45.44%   46.30%   +0.85%     
==========================================
  Files          38       42       +4     
  Lines        5886     6097     +211     
==========================================
+ Hits         2675     2823     +148     
- Misses       2988     3047      +59     
- Partials      223      227       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flostadler flostadler merged commit eafde1c into master Nov 8, 2024
18 checks passed
@flostadler flostadler deleted the flostadler/cfn-custom-resource-aws-clients branch November 8, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants