Add utility functions for supporting CloudFormation CustomResources #1808
Conversation
|
This change is part of the following stack: Change managed by git-spice. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1808 +/- ##
==========================================
+ Coverage 46.51% 46.78% +0.27%
==========================================
Files 42 42
Lines 6127 6164 +37
==========================================
+ Hits 2850 2884 +34
- Misses 3050 3052 +2
- Partials 227 228 +1 ☔ View full report in Codecov by Sentry. |
provider/pkg/naming/convert.go
Outdated
| switch reflect.TypeOf(value).Kind() { | ||
| case reflect.Map: | ||
| valueMap, ok := value.(map[string]interface{}) | ||
| if !ok { |
There was a problem hiding this comment.
Under what circumstance would this happen (!ok)? Should we throw an error here instead?
There was a problem hiding this comment.
In this case it shouldn't happen because CloudFormation only supports strings as keys.
Throwing sounds more apt in this case. Will change it accordingly!
There was a problem hiding this comment.
I actually ended up changing the implementation to allow arbitrary map keys. That way the method is cleaner and we don't need to worry about somebody using it in the future for another usecase and tripping over it only supporting string-indexed maps
provider/pkg/naming/convert.go
Outdated
| if !ok { | ||
| return value | ||
| } | ||
| result := map[string]interface{}{} |
There was a problem hiding this comment.
Could we just call ToStringifiedMap instead to avoid duplicating the code?
flostadler
force-pushed
the
flostadler/cfn-custom-resource-helpers
branch
from
60b5047
to
4cd4ddb
Compare
This change adds utility methods needed for supporting CloudFormation custom resources.
The main part of this change is a method for deeply converting all primitive values in a
map[string]interface{}to strings. This is needed because CloudFormation has this behavior: aws-cloudformation/cloudformation-coverage-roadmap#1037