-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compute "tags"
in Check
#2655
Merged
Merged
Compute "tags"
in Check
#2655
Commits on Aug 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for dc1eb0b - Browse repository at this point
Copy the full SHA dc1eb0bView commit details -
Test that we set "tags" on creation
TF does, and if we assume that "tags" is set correctly, we then get the expected diff.
Configuration menu - View commit details
-
Copy full SHA for 8d286ae - Browse repository at this point
Copy the full SHA 8d286aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 356ea90 - Browse repository at this point
Copy the full SHA 356ea90View commit details -
This fix takes effect during Check, which occurs before Diff. We don't need to do anything special for Diff now.
Configuration menu - View commit details
-
Copy full SHA for 8e162a2 - Browse repository at this point
Copy the full SHA 8e162a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for b65515c - Browse repository at this point
Copy the full SHA b65515cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 512e265 - Browse repository at this point
Copy the full SHA 512e265View commit details -
The previous fix works on all resources... except our s3legacy bucket because it was not updated to use upstream's new tags strategy. I have changed our fork to use the new strategy. The change is here: https://github.com/pulumi/terraform-provider-aws/compare/patched-v5.9.0...patched-v5.9.0-with-modern-s3legacy-tags?expand=1
Configuration menu - View commit details
-
Copy full SHA for 56e0b91 - Browse repository at this point
Copy the full SHA 56e0b91View commit details -
Configuration menu - View commit details
-
Copy full SHA for 450c82a - Browse repository at this point
Copy the full SHA 450c82aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8cffcbf - Browse repository at this point
Copy the full SHA 8cffcbfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bbe42a - Browse repository at this point
Copy the full SHA 3bbe42aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b82b56a - Browse repository at this point
Copy the full SHA b82b56aView commit details -
Add a test for aws:s3:BucketV2
We are seeing tests fail for aws:cognito:UserPool but I know this works for aws:s3:BucketV2. These are both SDKv2 resources. Since they work differently I have ensured that both are tested.
Configuration menu - View commit details
-
Copy full SHA for 12ed527 - Browse repository at this point
Copy the full SHA 12ed527View commit details -
Skip aws:cognito:UserPool test
This resource is broken upstream, so we skip the test here.
Configuration menu - View commit details
-
Copy full SHA for a50c6ba - Browse repository at this point
Copy the full SHA a50c6baView commit details -
I have left skeleton code for GRPC based testing, as I often find it useful when debugging locally. I have noted that it does not run in CI, and is just there for local development.
Configuration menu - View commit details
-
Copy full SHA for 1fd15a3 - Browse repository at this point
Copy the full SHA 1fd15a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd37ad2 - Browse repository at this point
Copy the full SHA fd37ad2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.