Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute "tags" in Check #2655

Merged
merged 15 commits into from
Aug 4, 2023
Merged

Compute "tags" in Check #2655

merged 15 commits into from
Aug 4, 2023

Commits on Aug 4, 2023

  1. Add GRPC test to replicate 2633

    @iwahbe
    iwahbe committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    dc1eb0b View commit details
    Browse the repository at this point in the history

  2. Test that we set "tags" on creation 

    TF does, and if we assume that "tags" is set correctly, we then get the expected diff.
    @iwahbe
    iwahbe committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    8d286ae View commit details
    Browse the repository at this point in the history

  3. Ensure valid diffs by overriding check

    @iwahbe
    iwahbe committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    356ea90 View commit details
    Browse the repository at this point in the history

  4. Remove .XComputeInput 

    This fix takes effect during Check, which occurs before Diff. We don't need to do anything
special for Diff now.
    @iwahbe
    iwahbe committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    8e162a2 View commit details
    Browse the repository at this point in the history

  5. Depend on pulumi/pulumi-terraform-bridge#1310

    @iwahbe
    iwahbe committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    b65515c View commit details
    Browse the repository at this point in the history

  6. Turn tests back on

    @iwahbe
    iwahbe committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    512e265 View commit details
    Browse the repository at this point in the history

  7. Consume upstream changes 

    The previous fix works on all resources... except our s3legacy bucket because it was not
updated to use upstream's new tags strategy. I have changed our fork to use the new
strategy.

The change is here:
https://github.com/pulumi/terraform-provider-aws/compare/patched-v5.9.0...patched-v5.9.0-with-modern-s3legacy-tags?expand=1
    @iwahbe
    iwahbe committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    56e0b91 View commit details
    Browse the repository at this point in the history

  8. Explain .Mappable() has the same shape as NewTagConfig expected

    @iwahbe
    iwahbe committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    450c82a View commit details
    Browse the repository at this point in the history

  9. Template out YAML Tests

    @iwahbe
    iwahbe committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    8cffcbf View commit details
    Browse the repository at this point in the history

  10. Accommodate aws:cognito:UserPool

    @iwahbe
    iwahbe committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    3bbe42a View commit details
    Browse the repository at this point in the history

  11. Switch to environment for pf

    @iwahbe
    iwahbe committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    b82b56a View commit details
    Browse the repository at this point in the history

  12. Add a test for aws:s3:BucketV2 

    We are seeing tests fail for aws:cognito:UserPool but I know this works for
aws:s3:BucketV2. These are both SDKv2 resources. Since they work differently I have
ensured that both are tested.
    @iwahbe
    iwahbe committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    12ed527 View commit details
    Browse the repository at this point in the history

  13. Skip aws:cognito:UserPool test 

    This resource is broken upstream, so we skip the test here.
    @iwahbe
    iwahbe committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    a50c6ba View commit details
    Browse the repository at this point in the history

  14. Remove outdated tests 

    I have left skeleton code for GRPC based testing, as I often find it useful when debugging
locally. I have noted that it does not run in CI, and is just there for local development.
    @iwahbe
    iwahbe committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    1fd15a3 View commit details
    Browse the repository at this point in the history

  15. Don't pass empty tags properties

    @iwahbe
    iwahbe committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    fd37ad2 View commit details
    Browse the repository at this point in the history