Replace Terraform with Pulumi to stop eliding iam.PolicyAttachment docs #4882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjeffryes
approved these changes
Dec 4, 2024
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
iwahbe
approved these changes
Dec 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4882 +/- ##
==============================
==============================
☔ View full report in Codecov by Sentry. |
|
This PR has been shipped in release v6.64.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
iam.PolicyAttachmentresource assumes exclusive management of IAM policies. Across the entire AWS account, all of the users/roles/groups to which a single policy is attached must be declared by a singleiam.PolicyAttachmentresource. This means that even any users/roles/groups that have the attached policy via any other mechanism (including other Pulumi resources) will have that attached policy revoked by this resource when it's deleted.This is quite surprising to users, especially because there's no mention of it in the Pulumi docs.
The warnings from the upstream provider were not carried into Pulumi docs because they included
Terraformand were elided. This fixes it.Fixes #4872
Relates to pulumi/pulumi-terraform-bridge#2251