Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test sharding #4912

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Test sharding #4912

wants to merge 9 commits into from

Conversation

blampe
Copy link
Contributor

@blampe blampe commented Dec 11, 2024

No description provided.

Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link
Contributor

@corymhall corymhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!! 🤩

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.41%. Comparing base (6d1326d) to head (ef4be97).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4912   +/-   ##
=======================================
  Coverage   24.41%   24.41%           
=======================================
  Files         360      360           
  Lines      143270   143270           
=======================================
  Hits        34984    34984           
  Misses     108187   108187           
  Partials       99       99           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t0yv0
Copy link
Member

t0yv0 commented Dec 16, 2024

This file was missing a warning that it is auto-generated. Fixed now in https://github.com/pulumi/ci-mgmt/pull/1231/files

@blampe what's next for this PR can we close? I assume once the changes make it to ci-mgmt and your latest fixes to AWS specifics this can "naturally" be updated through ci-mgmt?

@blampe blampe marked this pull request as draft December 16, 2024 21:05
@blampe
Copy link
Contributor Author

blampe commented Dec 16, 2024

PR can we close? I assume once the changes make it to ci-mgmt and your latest fixes to AWS specifics this can "naturally" be updated through ci-mgmt?

@t0yv0 yes, after pulumi/ci-mgmt#1217 merges we will be able to set shards: 15 in .ci-mgmt.yaml to start generating sharded workflows.

I marked this as a draft since I'll be re-using it occasionally to confirm I haven't broken anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants