Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate labels regression tests #1854

Merged
merged 6 commits into from
Mar 21, 2024

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Mar 21, 2024

Regression tests for #1843

Issue fixed in pulumi/pulumi-terraform-bridge#1757

@VenelinMartinov VenelinMartinov marked this pull request as draft March 21, 2024 11:48
@VenelinMartinov VenelinMartinov changed the base branch from master to vvm/gcp_examples_test_defaults March 21, 2024 11:48
@VenelinMartinov
Copy link
Contributor Author

VenelinMartinov commented Mar 21, 2024

Testing against the bridge master no longer reproduces the issue.

Seems like we have already fixed this in pulumi/pulumi-terraform-bridge#1757 - I confirmed by reverting the commit and the error triggers again.

Copy link

Does the PR have any schema changes?

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@VenelinMartinov VenelinMartinov changed the title Fix duplicate labels issue Duplicate labels regression tests Mar 21, 2024
@VenelinMartinov VenelinMartinov marked this pull request as ready for review March 21, 2024 12:07
Base automatically changed from vvm/gcp_examples_test_defaults to master March 21, 2024 12:12
Copy link
Contributor

@guineveresaenger guineveresaenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the PR description with the link to the bridge fix for easier discoverability in the future?

Thanks for these!

@VenelinMartinov VenelinMartinov merged commit 89c9fae into master Mar 21, 2024
17 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/fix_duplicate_labels_issue branch March 21, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants