-
Notifications
You must be signed in to change notification settings - Fork 145
Conversation
Your site preview for commit e7f9442 is ready! 🎉 http://pulumi-hugo-origin-pr-4158-e7f94426.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit 6f90a9a is ready! 🎉 http://pulumi-hugo-origin-pr-4158-6f90a9af.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit f40fe25 is ready! 🎉 http://pulumi-hugo-origin-pr-4158-f40fe25f.s3-website.us-west-2.amazonaws.com. |
This is how it works in the Registry filters, too (i.e., the checkboxes are ORs rather than ANDs). This would be helpful for things like |
@sean1588 @cnunciato I'll change the filters from AND to OR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I agree with Sean, though, that we probably want the filters to be ORs rather than ANDs. Otherwise, only a few tiny nits with suggestions.
|
||
&:hover { | ||
@apply text-black; | ||
background-color: #e8e8ec; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we choose a gray from the palette for this one (and also the one below)? Maybe 300
? That seems plenty close. 😄
It looks like this is the hex value for 350
in the Sass, but that value doesn't exist in the Tailwind config -- no idea why, but it probably should! If we really want 350
, we should add it there also, but IMO 300
looks fine too. Up to you.
style/tailwind adjustments Co-authored-by: Christian Nunciato <[email protected]>
Your site preview for commit 6d7676a is ready! 🎉 http://pulumi-hugo-origin-pr-4158-6d7676aa.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit abe002f is ready! 🎉 http://pulumi-hugo-origin-pr-4158-abe002f0.s3-website.us-west-2.amazonaws.com. |
languages: [] | ||
clouds: ["DigitalOcean"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The filters are OR'd except for upcoming/on-demand (since the content lives under tabs) so the only DigitalOcean content shows up under the on-demand tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh -- so the tabs behave like a filter also, then. That seems like a design bug -- makes it look like we don't have content we actually do. 😬
We don't need to block on it, but we should file a follow-up issue for it, as I'm sure someone else will bump into it and get the wrong impression. Unless you can think of an easy solution to include in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really have a solution in mind so maybe we need some UX support? I created a follow-up issue for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock, but we should file an issue for the tabs hiding filtered content and link it to this one if we decide to go that route.
Description
Filters for resources, added filters for skill level, cloud provider, topic, and programming language
Fixes https://github.com/pulumi/marketing/issues/822.
Checklist: