Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Sarah/filter #4158

Merged
merged 13 commits into from
Apr 12, 2024
Merged

Sarah/filter #4158

merged 13 commits into from
Apr 12, 2024

Conversation

shughes26
Copy link
Contributor

@shughes26 shughes26 commented Apr 9, 2024

Description

Filters for resources, added filters for skill level, cloud provider, topic, and programming language

Fixes https://github.com/pulumi/marketing/issues/822.

Checklist:

  • I have reviewed the style guide.
  • If blogging, I have reviewed the blogging guide.
  • I have manually confirmed that all new links work.
  • I added aliases (i.e., redirects) for all filename changes.
  • If making css changes, I rebuilt the bundle.

@shughes26 shughes26 requested review from cnunciato and sean1588 April 9, 2024 22:41
@shughes26 shughes26 requested a review from isaac-pulumi as a code owner April 9, 2024 22:41
@pulumi-bot
Copy link
Collaborator

Your site preview for commit e7f9442 is ready! 🎉

http://pulumi-hugo-origin-pr-4158-e7f94426.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 6f90a9a is ready! 🎉

http://pulumi-hugo-origin-pr-4158-6f90a9af.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit f40fe25 is ready! 🎉

http://pulumi-hugo-origin-pr-4158-f40fe25f.s3-website.us-west-2.amazonaws.com.

@sean1588
Copy link
Member

would there be a way for you to have the groups within each filter only allow one selection, so if you choose aws, it deselects azure? When both are selected it says there are no matches. I guess maybe another option would be to OR the filters selections together rather than AND, so it would show all workshops that are aws or azure.

Screen Shot 2024-04-10 at 2 48 24 PM

@cnunciato
Copy link
Contributor

cnunciato commented Apr 10, 2024

I guess maybe another option would be to OR the filters selections together rather than AND

This is how it works in the Registry filters, too (i.e., the checkboxes are ORs rather than ANDs). This would be helpful for things like Containers and Docker, which are similar enough that you'd probably want to see them at the same time.

@shughes26
Copy link
Contributor Author

@sean1588 @cnunciato I'll change the filters from AND to OR

Copy link
Contributor

@cnunciato cnunciato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I agree with Sean, though, that we probably want the filters to be ORs rather than ANDs. Otherwise, only a few tiny nits with suggestions.

themes/default/layouts/resources/list.html Outdated Show resolved Hide resolved
themes/default/theme/src/scss/_event-list.scss Outdated Show resolved Hide resolved
themes/default/theme/src/scss/_event-list.scss Outdated Show resolved Hide resolved

&:hover {
@apply text-black;
background-color: #e8e8ec;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we choose a gray from the palette for this one (and also the one below)? Maybe 300? That seems plenty close. 😄

It looks like this is the hex value for 350 in the Sass, but that value doesn't exist in the Tailwind config -- no idea why, but it probably should! If we really want 350, we should add it there also, but IMO 300 looks fine too. Up to you.

themes/default/theme/src/scss/_event-list.scss Outdated Show resolved Hide resolved
style/tailwind adjustments

Co-authored-by: Christian Nunciato <[email protected]>
@pulumi-bot
Copy link
Collaborator

Your site preview for commit 6d7676a is ready! 🎉

http://pulumi-hugo-origin-pr-4158-6d7676aa.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit abe002f is ready! 🎉

http://pulumi-hugo-origin-pr-4158-abe002f0.s3-website.us-west-2.amazonaws.com.

languages: []
clouds: ["DigitalOcean"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it when I choose this, I get no results?

image

I get this with others as well, like CodeFresh in the Topics menu, Azure, etc. Is this because they're in the past, and that's preventing them from displaying?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filters are OR'd except for upcoming/on-demand (since the content lives under tabs) so the only DigitalOcean content shows up under the on-demand tab.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh -- so the tabs behave like a filter also, then. That seems like a design bug -- makes it look like we don't have content we actually do. 😬

We don't need to block on it, but we should file a follow-up issue for it, as I'm sure someone else will bump into it and get the wrong impression. Unless you can think of an easy solution to include in this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really have a solution in mind so maybe we need some UX support? I created a follow-up issue for this

Copy link
Contributor

@cnunciato cnunciato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock, but we should file an issue for the tabs hiding filtered content and link it to this one if we decide to go that route.

@shughes26 shughes26 merged commit cbd498d into master Apr 12, 2024
2 checks passed
@shughes26 shughes26 deleted the sarah/filter branch April 12, 2024 17:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants