Fix example programs, bring the tests back to green #4159
Conversation
|
Your site preview for commit 4c69bac is ready! 🎉 http://pulumi-hugo-origin-pr-4159-4c69bac9.s3-website.us-west-2.amazonaws.com. |
cnunciato
force-pushed
the
cnunciato/fix-another-example
branch
from
4c69bac to
b75b7e0
Compare
|
Your site preview for commit b75b7e0 is ready! 🎉 http://pulumi-hugo-origin-pr-4159-b75b7e0c.s3-website.us-west-2.amazonaws.com. |
cnunciato
force-pushed
the
cnunciato/fix-another-example
branch
from
b75b7e0 to
4a539d4
Compare
|
Your site preview for commit 4a539d4 is ready! 🎉 http://pulumi-hugo-origin-pr-4159-4a539d43.s3-website.us-west-2.amazonaws.com. |
cnunciato
force-pushed
the
cnunciato/fix-another-example
branch
from
4a539d4 to
36abc83
Compare
|
Your site preview for commit 36abc83 is ready! 🎉 http://pulumi-hugo-origin-pr-4159-36abc83f.s3-website.us-west-2.amazonaws.com. |
cnunciato
force-pushed
the
cnunciato/fix-another-example
branch
from
36abc83 to
d1086cf
Compare
|
Your site preview for commit d1086cf is ready! 🎉 http://pulumi-hugo-origin-pr-4159-d1086cf0.s3-website.us-west-2.amazonaws.com. |
| continue | ||
| fi | ||
|
|
||
| # Optionally test only from the specified example forward by setting ONLY_TEST_FROM="<example-path>". |
There was a problem hiding this comment.
Minor enhancement to make it easier to run the tests locally (so you don't have to sit through all of them again after making a fix).
| "Resource": "%s/*" | ||
| }] | ||
| }""", arn)); | ||
| var policyDocument = bucket.arn().applyValue(arn -> serializeJson( |
There was a problem hiding this comment.
This was necessary because Java 11 doesn't support multiline strings specified in this way. We use serializeJson elsewhere for this, so I went with that for consistency.
|
Your site preview for commit 0d97aca is ready! 🎉 http://pulumi-hugo-origin-pr-4159-0d97aca8.s3-website.us-west-2.amazonaws.com. |
| "Resource": f"{arn}/*" | ||
| }] | ||
| })) | ||
| s3_bucket_policy_document = s3_bucket.arn.apply( |
There was a problem hiding this comment.
Changes in this file are just the result of running black on it.
| - "s3:PutObjectAcl" | ||
| Resource: | ||
| Fn::Sub: "${myBucket.arn}/*" | ||
| fn::toJSON: |
There was a problem hiding this comment.
This was failing as well on a YAML-related syntax error.
| value: ${myBucket.id} | ||
| bucket_arn: | ||
| value: ${myBucket.arn} | ||
| bucket_name: ${myBucket.id} |
There was a problem hiding this comment.
No need to export value wrappers here, so since the other examples don't use them, we can remove them.
| @@ -1,5 +0,0 @@ | |||
| module aws-simulated-server-interpolate-go | |||
There was a problem hiding this comment.
This was causing the script to fail because this example doesn't exist.
cnunciato
changed the title
|
Your site preview for commit b9c29d4 is ready! 🎉 http://pulumi-hugo-origin-pr-4159-b9c29d45.s3-website.us-west-2.amazonaws.com. |
Makes some additional fixes for failures I noticed when running the tests for #4157.
Should make all the tests 🟢 again. (Also bumps all the Go programs by running
make upgrade-programs.)Fixes pulumi/docs#11463.
Fixes pulumi/docs#11483. (This has also been failing for several weeks.)