Generated Utilities.java file does not use the language.java.basePackage property

[hansbarnard]

What happened?

I set the java basePackage property in the schema.json file as follows:

    "language": {
        "java": {
            "basePackage": "com.xxxxx",
...

When using this plugin the generated java SDK fails with an Exception because it cannot find the file version.txt. It is expecting the file on the classpath at com/pulumi/ipidp/version.txt. Instead this file is on the classpath at com/pulumi/xxxxx/version.txt.

The problem is that the generated java class sdk/java/src/main/java/com/xxxxx/ipidp/Utilities.java is hardcoded to expect this file at com/pulumi/ipidp/version.txt.

Expected Behavior

The generated java class sdk/java/src/main/java/com/xxxxx/ipidp/Utilities.java should use the basePackage property to resolve the version.txt file.

Steps to reproduce

Clone the repo https://github.com/hansbarnard/pulumi-test-java, and execute make build_java.

Inspect line 78 in the generated Utilities.java file: https://github.com/hansbarnard/pulumi-test-java/blob/main/sdk/java/src/main/java/com/xxxxx/ipidp/Utilities.java#L78

Output of pulumi about

Not applicable

Additional context

Using java-gen v0.9.3

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

[muhlba91]

i can confirm this. the result in my case is:

    static {
        var resourceName = "com/pulumi/proxmoxve/version.txt";
        var versionFile = Utilities.class.getClassLoader().getResourceAsStream(resourceName);
        if (versionFile == null) {
            throw new IllegalStateException(
                    String.format("expected resource '%s' on Classpath, not found", resourceName)
            );
        }
        version = new BufferedReader(new InputStreamReader(versionFile))
                .lines()
                .collect(Collectors.joining("\n"))
                .trim();
    }

var resourceName = "com/pulumi/proxmoxve/version.txt"; should reference the correct base package - e.g. var resourceName = "io/muehlbachler/pulumi/proxmoxve/version.txt";

as far as i can tell this is due to https://github.com/pulumi/pulumi-java/blob/main/pkg/codegen/java/gen.go#LL1759C60-L1759C60 where defaultBasePackage (references hard-coded value here: https://github.com/pulumi/pulumi-java/blob/main/pkg/codegen/java/package_info.go#L21) gets taken instead of the basePackageName in the mod variable (i guess?).

similar to #1118 this is preventing third-party publishers.

[muhlba91]

@dixler are there any updates to that? as far as i can tell this and #1109 are definitely still blocking third-party publishers.

[runlevel5]

Is there any update on this work? Cheers

[philippart-s]

Hi, same pb for me and it's a blocker for my company (OVHcloud) to use this part of Pulumi

[t0yv0]

Having a Quick Look, the version.txt is generated by gradle in https://github.com/hansbarnard/pulumi-test-java/blob/main/sdk/java/build.gradle#L65 - which is based on

project.name

which for this project is based on

https://github.com/hansbarnard/pulumi-test-java/blob/main/sdk/java/settings.gradle#L13

which is also generated apparently

https://github.com/pulumi/pulumi-java/blob/main/pkg/codegen/java/templates_gradle.go#L139

via

https://github.com/pulumi/pulumi-java/blob/main/pkg/codegen/java/settings.gradle.template#L13

[EronWright]

Thanks @tmeckel for the fix!