Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct module name to create VersionPath #1362

Merged
merged 1 commit into from
May 24, 2024
Merged

fix: correct module name to create VersionPath #1362

merged 1 commit into from
May 24, 2024

Conversation

tmeckel
Copy link
Contributor

@tmeckel tmeckel commented May 21, 2024

Description

Fixes #1110

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@tmeckel
fix: use mod.basePackageName instead of defaultBasePackage to create …
294d6b0 
…VersionPath property correctly in pkg/codegen/java/gen.go
@tmeckel
Copy link
Contributor Author

tmeckel commented May 21, 2024

@t0yv0 As discussed: mini fix. Lacking at least one regression test.

@t0yv0 t0yv0 self-requested a review May 24, 2024 17:15
@EronWright EronWright marked this pull request as ready for review May 24, 2024 17:29
@t0yv0
Copy link
Member

t0yv0 commented May 24, 2024

Checking this with @EronWright this clearly makes things better as the previous code assumed com.pulumi let's merge

EronWright
EronWright approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@EronWright EronWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this fix and it seems to work. I'm merging it now to include in the v0.12 release.

@EronWright EronWright merged commit 8022914 into pulumi:main May 24, 2024
13 of 14 checks passed
@tmeckel tmeckel deleted the fix/1110 branch May 24, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t0yv0 t0yv0 t0yv0 approved these changes

@EronWright EronWright EronWright approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generated Utilities.java file does not use the language.java.basePackage property
3 participants
@tmeckel @t0yv0 @EronWright