Fix no longer being able to place types in top-level modules #1300 #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This restores the ability to place resources into top-level modules by making tokens like "myprovider:mymodule:MyResource", something that accidentally regressed and was not caught as most Pulumi-managed providers opt for a submodule scheme like "myprovider:mymodule/mysubmodule:MyResource", and the code started to accidentally assume this scheme.
|
Diff for pulumi-azuread with merge commit 0920069 |
|
Diff for pulumi-random with merge commit 0920069 |
thomas11
reviewed
Jul 25, 2023
|
Diff for pulumi-azuread with merge commit 28fecd6 |
|
Diff for pulumi-random with merge commit 28fecd6 |
thomas11
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1300
This restores the ability to place resources into top-level modules by making tokens like "myprovider:mymodule:MyResource", something that accidentally regressed and was not caught as most Pulumi-managed providers opt for a submodule scheme like "myprovider:mymodule/mysubmodule:MyResource", and the code started to accidentally assume this scheme.